6 Mar
2015
6 Mar
'15
12:35 p.m.
On Mon, Mar 02, 2015 at 03:36:17PM +0800, han.lu@intel.com wrote:
+static int hsw_waves_param_get(struct snd_kcontrol *kcontrol,
struct snd_ctl_elem_value *ucontrol)+{
- /* keep an empty function here to match alsa-lib calling */
- return 0;
+}
No, if it's valid to omit this we should be able to remove the function - but I'd really expect to always be able to read the current state of any control. Applications should be able to do that and then write the value back without changing anything. Either we should actually read things back or this should return an error (which is presumably what the core does if the function is missing).