Re: [alsa-devel] [PATCH] ASoC: tegra: s/IS_ERR_OR_NULL/IS_ERR/ for clk_get_sys

On Tue, 2011-01-11 at 12:48 -0700, Stephen Warren wrote:

A recent discussion on linux-arm-kernel noted that the value returned by clk_get_sys is an opaque token, and not strictly a pointer; it is meaningful only to the clock API, clients should not dereference the value, and the clock API must accept any non-IS_ERR value it returned.

Hence, only IS_ERR is appropriate to interpret the result, not IS_ERR_OR_NULL.

I checked that clk_get_sys in both ASoC's for-next and Tegra's for-next do behave as described; NULL is not returned in the case of error.

Signed-off-by: Stephen Warren swarren@nvidia.com

Acked-by: Liam Girdwood lrg@slimlogic.co.uk