Re: [alsa-devel] [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4

23 Dec 2010


      Hi,
...
From: alsa-devel-bounces@alsa-project.org [alsa-devel-bounces@alsa-project.org] on behalf of Ujfalusi Peter (Nokia-MS/Tampere)
Sent: Thursday, December 23, 2010 08:42
To: lrg@slimlogic.co.uk; jhnikula@gmail.com
Cc: magi.olaya@ti.com; alsa-devel@alsa-project.org; broonie@opensource.wolfsonmicro.com
Subject: Re: [alsa-devel] [PATCH] ASoC: mcbsp: Add McBSP support for OMAP4
...
In the patch:
@@ -623,6 +652,9 @@ static int omap_mcbsp_dai_set_dai_sysclk(struct snd_soc_dai *cpu_dai,
                if (cpu_class_is_omap1()) {
                        err = -EINVAL;
                        break;

          } else if (cpu_is_omap44xx()) {


                  regs->srgr2     &= ~CLKSM;




There's no need to clear the CLKSM, since it is by default not set.
IMHO you shall handle the OMAP4 in a same way as we handle OMAP3.
By doing nothing here.

                  break;



I think you should not break here, since you might want to select the CLKS/PRCM with the next
call...
...
            }
            err = omap2_mcbsp_set_clks_src(mcbsp_data->bus_id,
                                           MCBSP_CLKS_PRCM_SRC);



Otherwise:
Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com
Just noticed that, this patch is already in, but the issues, I have commented has to
be fixed in order to have proper support for OMAP4.
Peter

    

peter.ujfalusi＠nokia.com