-----Original Message----- From: linux-clk-owner@vger.kernel.org [mailto:linux-clk-owner@vger.kernel.org] On Behalf Of Stephen Boyd Sent: 08 September, 2016 2:52 To: Tirdea, Irina Cc: linux-clk@vger.kernel.org; Michael Turquette; alsa-devel@alsa-project.org; Mark Brown; Takashi Iwai; Bossart, Pierre-louis; Pierre- Louis Bossart Subject: Re: [PATCH v2] clk: x86: Add Atom PMC platform clocks
On 09/07, Irina Tirdea wrote:
@@ -152,6 +155,17 @@ #define SLEEP_TYPE_S5 0x1C00 #define SLEEP_ENABLE 0x2000
+struct pmc_clk {
- const char *name;
- unsigned long freq;
- const char *parent_name;
+};
+struct pmc_clk_data {
- void __iomem *base;
- const struct pmc_clk *clks;
+};
Can you please put these structures in include/linux/platform_data/ with some new file? That way we don't need to have any architecture specific configuration to test build the clk driver and we can drop the asm include fro mthe clk driver too.
Thanks for the review!
Sure, I will make all the changes you pointed out.
I assume I will also need to allow the driver to be compiled if COMPILE_TEST is set. Is that correct or is there another way to test build the driver for any architecture?
Thanks, Irina