28 Nov
2018
28 Nov
'18
12:18 p.m.
On Tuesday 27 November 2018 09:44:18 Pavel Machek wrote:
Looks good... except one detail: you have "tpacpi::micmute" and "dell::micmute". I know it follows "tradition", but we are trying to fix that at the moment. Laptop micmute button is a laptop micmute button, and userspace should not need to know what prefix to use depending on vendor.
I'd suggest using "sys::micmute".
I can imagine that in future some devices like keyboards would have also mute led. We already have keyboards with mute key, so it is something not unrealistic. What should be name convention for these mute leds?
Is not "sys::" prefix too generic?
--
Pali Rohár
pali.rohar@gmail.com