Dnia niedziela, 8 października 2023 20:03:21 CEST kernel test robot pisze:
Hi Janusz,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next] [also build test ERROR on linus/master v6.6-rc4 next-20231006] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Janusz-Krzysztofik/ASoC-ti-am... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20231008135601.542356-1-jmkrzyszt%40gmail.com patch subject: [PATCH] ASoC: ti: ams-delta: Allow it to be test compiled config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20231009/202310090122.Yp9JndiQ-lkp@i...) compiler: sh4-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231009/202310090122.Yp9JndiQ-lkp@i...)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot lkp@intel.com | Closes: https://lore.kernel.org/oe-kbuild-all/202310090122.Yp9JndiQ-lkp@intel.com/
All errors (new ones prefixed by >>):
sound/soc/ti/ams-delta.c:401:24: error: initialization of 'void (*)(struct tty_struct *, const u8 *, const u8 *, size_t)' {aka 'void (*)(struct tty_struct *, const unsigned char *, const unsigned char *, unsigned int)'} from incompatible pointer type 'void (*)(struct tty_struct *, const u8 *, const char *, int)' {aka 'void (*)(struct tty_struct *, const unsigned char *, const char *, int)'} [-Werror=incompatible-pointer-types]
401 | .receive_buf = cx81801_receive, | ^~~~~~~~~~~~~~~sound/soc/ti/ams-delta.c:401:24: note: (near initialization for 'cx81801_ops.receive_buf') cc1: some warnings being treated as errors
This is the error I reported and fixed in the recent "[PATCH] ASoC: ti: ams-delta: Fix cx81801_receive() argument types". This change just exhibits that error, still present in trees without that fix.
Mark, if you are OK with this change, could you please give your ack, like you did for the fix?
Greg, since you already added that fix to your tty-linux tree, commit b3fa3cf02e3c, could you please also take this patch?
Thanks, Janusz
vim +401 sound/soc/ti/ams-delta.c
6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 393 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 394 static struct tty_ldisc_ops cx81801_ops = { 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 395 .name = "cx81801", fbadf70a8053b3 sound/soc/ti/ams-delta.c Jiri Slaby 2021-05-05 396 .num = N_V253, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 397 .owner = THIS_MODULE, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 398 .open = cx81801_open, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 399 .close = cx81801_close, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 400 .hangup = cx81801_hangup, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 @401 .receive_buf = cx81801_receive, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 402 .write_wakeup = cx81801_wakeup, 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 403 }; 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 404 6d7f68a1eab3d5 sound/soc/omap/ams-delta.c Janusz Krzysztofik 2009-07-29 405