On 03/25/2014 07:30 AM, Mark Brown wrote:
On Mon, Mar 24, 2014 at 10:16:37AM +0800, oder_chiou@realtek.com wrote:
From: Oder Chiou oder_chiou@realtek.com
This patch adds the RT5639 codec driver.
Looking at the level of code similiarity between this and the rt5640 driver I can't help but think that these should be supported from a single driver - a few quick spot checks of the register map suggests that there's at least some overlap. There will need to be some device specific handling but it looks like there's more shared than not shared. What are the issues that prevent the code being shared, there may be something I've missed?
FWIW, I was informed internally (although this certainly isn't normative) that RT5639 is RT5640 plus a DSP, and otherwise compatible. Related, I have a board that has a RT5639 and I'm running the RT5640 driver on it for at least a simple use-case, without issue.