6 May
2016
6 May
'16
2:26 p.m.
On Thu, May 05, 2016 at 11:53:04AM +0100, Adam Thomson wrote:
This change converts the driver from using the of_* functions to using the device_* and fwnode_* functions for accssing DT related data. This is in preparation for updates to support ACPI based initialisation.
Is this *really* sensible? DT idioms don't always match up with ACPI idioms well and this isn't a trivial DT binding.
+static struct fwnode_handle *da7219_aad_of_named_fwhandle(struct device *dev,
const char *name)
+{
- struct fwnode_handle *child;
- struct device_node *of_node;
- /* Find first matching child node */
- device_for_each_child_node(dev, child) {
if (is_of_node(child)) {
of_node = to_of_node(child);
if (of_node_cmp(of_node->name, name) == 0)
return child;
}
- }
- return NULL;
+}
There's nothing device specific about this, it should go in generic code.