Re: [PATCH v2 2/2] ASoC: Intel: Skylake: Zero snd_ctl_elem_value

On Thu, Jan 21, 2021 at 06:16:44PM +0100, Ricardo Ribalda wrote:

Clear struct snd_ctl_elem_value before calling ->put() to avoid any data leak.

Reviewed-by: Andy Shevchenko andriy.shevchenko@linux.intel.com

Signed-off-by: Ricardo Ribalda ribalda@chromium.org

sound/soc/intel/skylake/skl-topology.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/skylake/skl-topology.c b/sound/soc/intel/skylake/skl-topology.c index 1ef30ca45410..b824086203b9 100644 --- a/sound/soc/intel/skylake/skl-topology.c +++ b/sound/soc/intel/skylake/skl-topology.c @@ -3632,7 +3632,7 @@ static void skl_tplg_complete(struct snd_soc_component *component) sprintf(chan_text, "c%d", mach->mach_params.dmic_num);

for (i = 0; i < se->items; i++) {

• 	struct snd_ctl_elem_value val;
  

• 	struct snd_ctl_elem_value val = {};
  
  if (strstr(texts[i], chan_text)) {
  	val.value.enumerated.item[0] = i;
  

-- 2.30.0.296.g2bfb1c46d8-goog