On Tue, Apr 06, 2021 at 12:50:15PM +0200, Jiri Prchal wrote:
Removed things which are in header file. Renamed functions and removed their I2C related code. Moved I2C code to separate file.
Signed-off-by: Jiri Prchal jiri.prchal@aksignal.cz
sound/soc/codecs/tlv320aic3x.c | 105 +++++++++------------------------ 1 file changed, 27 insertions(+), 78 deletions(-)
This is not moving the I2C code, this is just plain deleting it which will leave things broken after this patch - things should build and run after each patch in the series. As covered in submitting-patches.rst each commit should do one thing as a standalone patch, and the changelog for the patch should clearly describe what the patch does.
You probably want something like a patch to factor the I2C stuff out to a separate file and another to add the SPI support. Look at how other drivers have done this transition.
@@ -147,6 +140,7 @@ static const struct regmap_config aic3x_regmap = {
.cache_type = REGCACHE_RBTREE, }; +EXPORT_SYMBOL(aic3x_regmap_config);
Everything else in ASoC is EXPORT_SYMBOL_GPL(), why is this EXPORT_SYMBOL()?