Re: [alsa-devel] [PATCH 24/25] ASoC: soc-component: move snd_soc_component_stream_event()

Hi Charles

Thank you for your feedback I will fix it at v2

...

+int snd_soc_component_stream_event(struct snd_soc_dapm_context *dapm,

• 		   int event)
  

+{

• struct snd_soc_component *component = dapm->component;
• if (component->driver->stream_event)

• return component->driver->stream_event(component, event);
  

• return 0;

Minor nitpick but a blank line before the return would be more normal and consistent with your other patches.

...

@@ -2729,8 +2721,7 @@ static int snd_soc_component_initialize(struct snd_soc_component *component, dapm->idle_bias_off = !driver->idle_bias_on; dapm->suspend_bias_off = driver->suspend_bias_off; dapm->seq_notifier = snd_soc_component_seq_notifier;

• if (driver->stream_event)

• dapm->stream_event = snd_soc_component_stream_event;
  

• dapm->stream_event = snd_soc_component_stream_event;

Obviously same comment regarding the NULL checks in DAPM applies here.

Thanks, Charles