Re: [alsa-devel] [PATCH v3 2/2] ASoC: codecs: add support for TAS5720 digital amplifier

On 04/25/2016 03:17 PM, Andreas Dannenberg wrote:

The Texas Instruments TAS5720L/M device is a high-efficiency mono Class-D audio power amplifier optimized for high transient power capability to use the dynamic power headroom of small loudspeakers. Its digital time division multiplexed (TDM) interface enables up to 16 devices to share the same bus.

Signed-off-by: Andreas Dannenberg dannenberg@ti.com

sound/soc/codecs/Kconfig | 10 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/tas5720.c | 638 +++++++++++++++++++++++++++++++++++++++++++++ sound/soc/codecs/tas5720.h | 90 +++++++ 4 files changed, 740 insertions(+) create mode 100644 sound/soc/codecs/tas5720.c create mode 100644 sound/soc/codecs/tas5720.h

diff --git a/sound/soc/codecs/Kconfig b/sound/soc/codecs/Kconfig index 290f921..3949dae 100644 --- a/sound/soc/codecs/Kconfig +++ b/sound/soc/codecs/Kconfig @@ -125,6 +125,7 @@ config SND_SOC_ALL_CODECS select SND_SOC_TAS2552 if I2C select SND_SOC_TAS5086 if I2C select SND_SOC_TAS571X if I2C

• select SND_SOC_TAS5720 if I2C select SND_SOC_TFA9879 if I2C select SND_SOC_TLV320AIC23_I2C if I2C select SND_SOC_TLV320AIC23_SPI if SPI_MASTER

@@ -748,6 +749,15 @@ config SND_SOC_TAS571X tristate "Texas Instruments TAS5711/TAS5717/TAS5719/TAS5721 power amplifiers" depends on I2C

+config SND_SOC_TAS5720

• tristate "Texas Instruments TAS5720 Mono Audio amplifier"
• depends on I2C
• help

•  Enable support for Texas Instruments TAS5720L/M high-efficiency mono
  

•  Class-D audio power amplifiers. The devices use an I2C interface for
  

•  setup/control and support an optional GPIO interrupt signal for fault
  

•  reporting.
  

If fault reporting is no longer interrupt based could this be re-worded?

[...]

+static struct i2c_driver tas5720_i2c_driver = {

• .driver = {

• .name = "tas5720",
  

• .owner = THIS_MODULE,
  

This shouldn't be needed.

Andrew