13 Feb
2019
13 Feb
'19
1:07 p.m.
On 2/13/19 09:06, Krzysztof Kozlowski wrote:
@@ -742,7 +742,7 @@ static int i2s_hw_params(struct snd_pcm_substream *substream, switch (params_channels(params)) { case 6: val |= MOD_DC2_EN;
/* fall through */
/* Fall through */
Just to be sure - did you check whether this passes GCC -Wimplicit-fallthrough=3 (you need GCC v7)? It looks correct - like one of accepted patterns (https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html).
I just checked it now and with comment in upper case the warning is also being suppressed.
--
Regards,
Sylwester