On Fri, 26 Aug 2022 00:01:29 +0200, Luke D. Jones wrote:
Fixes up the pincfg for ASUS ROG Strix G15 (G533Z) laptop.
Signed-off-by: Luke D. Jones luke@ljones.dev
Just minor nitpicking:
--- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -5828,7 +5828,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec, struct alc_spec *spec = codec->spec; spec->parse_flags |= HDA_PINCFG_HEADSET_MIC; alc255_set_default_jack_type(codec);
- }
- } else alc_fixup_headset_mode(codec, fix, action);
}
Please avoid touching unnecessary parts.
@@ -8363,6 +8364,17 @@ static const struct hda_fixup alc269_fixups[] = { .type = HDA_FIXUP_FUNC, .v.func = alc294_fixup_gu502_hp, },
- [ALC285_FIXUP_ASUS_G533Z_PINS] = {
.type = HDA_FIXUP_PINS,.v.pins = (const struct hda_pintbl[]) {{ 0x14, 0x90170120 },{ 0x19, 0x03A11050 }, /* front HP mic */{ 0x1B, 0x03A11C30 }, /* rear external mic */{ 0x21, 0x03211420 }, /* front HP out */
We prefer the lower letters for hex numbers.
{ }},.chained = false,
This is initialization superfluous, please drop.
Last but not least, the subject prefix should be rather "ALSA:" instead of "sound:".
The same applied to the second patch. Could you try to address those and resubmit as v2?
thanks,
Takashi