At Wed, 4 Feb 2009 17:37:51 +0900, Kusanagi Kouichi wrote:
On Tue, Feb 03, 2009 at 03:36:20PM +0100, Takashi Iwai wrote:
Another concern is that I don't want to add the digital beep control unconditionally. On many devices, the beep is implemented in the old good analog way. We'd need to add the check of analog/digital beep in a new spec field and in the preset table not to duplicate beep controls on these.
I don't think such a check is needed. I presume that analog beep in is disabled while digital beep generetor is being used. Furthermore, keyboard bell rings only one device even if both HDA Digital PCBeep and PC Speaker have been registered.
However it's just annoying to have multiple controls for the very same purpose. If the digital beep works more reliably overall, let's get rid of all existing analog beep stuff. Having both makes no sense.
(Well, I don't remember exactly your patch so I suppose your patch doesn't remove the analog beep stuff... Anyway reposting the patch and checking it's still applicable to the latest driver code would be helpful :)
Ah! I see the point. There is no duplicated control because I didn't add any new controls. Existing beep control controls digital beep, too. Analog beep and digital beep look to be routed through the same path.
Fair enough.
Though, there is still one problem -- not all models enabled the analog beep path. So, the next step is to create beep controls in all possible situations.
But I'm going to apply your patch as now. Could you repost the patch with a proper summary, a changelog text and your sign-off so that I can apply it as is?
thanks,
Takashi