On Fri, 2010-12-03 at 17:25 +0800, Axel Lin wrote:
In alc5623_i2c_probe(), the default case for checking alc5623->id behaves the same as case 0x23. However, In alc5623_probe() the default case for checking alc5623->id becomes to be the same as case 0x21. This makes the meaning of default case inconsistent.
Since we have checked codec id in alc5623_i2c_probe() by comparing vid2 with id->driver_data, it is not possible to run into the default case now.
In case we may add more supported devices to alc5623_i2c_table in the future, this patch changes the default case return -EINVAL to let people know that they should not run into this case. They should also add a new case accordingly for the new id.
Signed-off-by: Axel Lin axel.lin@gmail.com
Acked-by: Liam Girdwood lrg@slimlogic.co.uk