On 29/03/2024 16:19, Mohammad Rafi Shaik wrote:
On 3/27/2024 6:39 PM, Dmitry Baryshkov wrote:
On Wed, 27 Mar 2024 at 13:34, Mohammad Rafi Shaikquic_mohs@quicinc.com wrote:
Add machine driver for qcm6490 SoC.
This initial supports which includes WSA883x Speakers with onboard DMIC connected to internal LPASS codec via VA macros respectively and also WCD937x based headset.
Add compatible for sound card on Qualcomm qcs6490 boards.
Granted that qcm6490 is similar to sc7280, is there any reason why you can not use one of the existing sound card drivers? Like sc7280.c or sc8280xp.c?
The qcs6490/qcm6490 has additional interfaces like MI2S, which requires additional machine driver modification.
Example : Required new DAPM widget change in machine driver for MI2S interface which is specific to qcs6490/qcm6490.
So, using new qcm6490 machine driver.
Will try to use existing sc8280xp.c machine driver.
In that case, if it does not fit into sc8280xp, it looks fine for a new driver. Maybe just mention this in commit msg.
Best regards, Krzysztof