El Mon, Aug 29, 2016 at 12:28:21PM -0700, Nicolin Chen deia:
Yes, it seems that it also tried to correct the clock sources as those were not available when adding the S/PDIF support at the first place.
I wonder if maybe they need to be defined, assigned or somehow listed elsewhere and they are not for wandboard quad (but are for other boards)?
The issue is fixed for me with this patch but I'm not sure what's the best way to help fix any issue someone else may have or what other info or test you might need. Any guidance welcome.
--- linux-4.7-no-spdif-out/arch/arm/boot/dts/imx6qdl.dtsi 2016-07-25 00:19:43.000000000 +0200 +++ linux-4.7/arch/arm/boot/dts/imx6qdl.dtsi 2016-08-28 17:59:14.276774409 +0200 @@ -240,9 +240,9 @@ <&sdma 15 18 0>; dma-names = "rx", "tx"; clocks = <&clks IMX6QDL_CLK_SPDIF_GCLK>, <&clks IMX6QDL_CLK_OSC>,
<&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_ASRC>,<&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_ESAI_EXTAL>,<&clks IMX6QDL_CLK_IPG>, <&clks IMX6QDL_CLK_MLB>,
<&clks IMX6QDL_CLK_SPDIF>, <&clks IMX6QDL_CLK_DUMMY>,<&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>,<&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_DUMMY>, <&clks IMX6QDL_CLK_SPBA>; clock-names = "core", "rxtx0", "rxtx1", "rxtx2",
This looks like that you merely revert the SPDIF_GCLK.
I revert only some clocks, yes. I left SPDIF_GCLK and CLK_SBPA intact. So it is a partial revert of the commit.
Would you please do a little debug using "#define DEBUG 1" and check printk from fsl_spdif_probe_txclk() to see the difference between before and after Shengjiu's commit?
Yes, but I'm compiling the kernel in the wandboard, so it'll take me some time.
Thank you.