Re: [alsa-devel] [PATCH] sound: constify functions in ac97

At Wed, 12 Jan 2011 14:44:07 +0200, Alexey Dobriyan wrote:

On Wed, Jan 12, 2011 at 1:03 PM, Hanno Böck hanno@hboeck.de wrote:

...

struct snd_ac97_build_ops {

• int (*build_3d) (struct snd_ac97 *ac97);
• int (*build_specific) (struct snd_ac97 *ac97);
• int (*build_spdif) (struct snd_ac97 *ac97);
• int (*build_post_spdif) (struct snd_ac97 *ac97);

• int (* const build_3d) (struct snd_ac97 *ac97);
• int (* const build_specific) (struct snd_ac97 *ac97);
• int (* const build_spdif) (struct snd_ac97 *ac97);
• int (* const build_post_spdif) (struct snd_ac97 *ac97);

#ifdef CONFIG_PM

• void (*suspend) (struct snd_ac97 *ac97);
• void (*resume) (struct snd_ac97 *ac97);

• void (* const suspend) (struct snd_ac97 *ac97);
• void (* const resume) (struct snd_ac97 *ac97);

#endif

• void (*update_jacks) (struct snd_ac97 *ac97);   /* for jack-sharing */

• /* for jack-sharing */
• void (* const update_jacks) (struct snd_ac97 *ac97);

Can we please not do this.

You made whole ops structure RO, this is enough.

Yes. Hanno, could you fix and resubmit?

thanks,

Takashi