At Sat, 19 Jan 2013 20:37:00 +0800, Raymond Yau wrote:
Refer to commit
http://git.kernel.org/?p=linux/kernel/git/tiwai/sound-unstable.git;a=commit;...
Do you mean user have to specify hint
- mixer_nid to analog the aa-path for creating those Mic/line playback
volume/switch ?
mixer_nid should be set in each caller, i.e. patch_ad1988(). It's just missing there. Of course, you can set it explicitly via a hint string by yourself later.
Can the auto parser find this mixer instead of hard code ?
Possible but not trivial.
- add_stereo_mix_input for the missing input source "mix"
This also depends on the codec and preference. I guess it'd make sense to enable it as default for AD1988x.
Do the user really need Line boost volume control ?
Node 0x3a [Audio Selector] wcaps 0x30010d: Stereo Amp-Out Control: name="Line Boost Volume", index=0, device=0 ControlAmp: chs=3, dir=Out, idx=0, ofs=0 Amp-Out caps: ofs=0x00, nsteps=0x03, stepsize=0x27, mute=0 Amp-Out vals: [0x03 0x03] Connection: 1 0x15
Well, it's a matter of taste. This has been requested some times, but I'm open about the default behavior.
Is it feasbile at this stage to implement the centre and lfe swap switch when orange jack and retasked rear mic jack support L/R swap ?
Node 0x24 [Pin Complex] wcaps 0x40098d: Stereo Amp-Out R/L Control: name="Center Playback Switch", index=0, device=0 ControlAmp: chs=1, dir=Out, idx=0, ofs=0 Control: name="LFE Playback Switch", index=0, device=0 ControlAmp: chs=2, dir=Out, idx=0, ofs=0 Control: name="Line Out CLFE Jack", index=0, device=0 Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 Amp-Out vals: [0x00 0x00] Pincap 0x00000037: IN OUT Detect Trigger ImpSense Pin Default 0x01016011: [Jack] Line Out at Ext Rear Conn = 1/8, Color = Orange DefAssociation = 0x1, Sequence = 0x1 Pin-ctls: 0x40: OUT Unsolicited: tag=04, enabled=1 Connection: 1 0x27
Node 0x17 [Pin Complex] wcaps 0x40098d: Stereo Amp-Out R/L Control: name="Rear Mic Jack", index=0, device=0 Amp-Out caps: ofs=0x00, nsteps=0x00, stepsize=0x00, mute=1 Amp-Out vals: [0x80 0x80] Pincap 0x00003737: IN OUT Detect Trigger ImpSense Vref caps: HIZ 50 GRD 80 100 Pin Default 0x01a19020: [Jack] Mic at Ext Rear Conn = 1/8, Color = Pink DefAssociation = 0x2, Sequence = 0x0 Pin-ctls: 0x24: IN VREF_80 Unsolicited: tag=07, enabled=1 Connection: 1 0x26
Such a feature is basically codec specific. This should be implemented in the AD codec driver side.
Takashi