On Fri, 26 Jul 2013 00:05:33 +0100 Russell King - ARM Linux linux@arm.linux.org.uk wrote:
On Thu, Jul 25, 2013 at 08:19:05PM +0100, Mark Brown wrote:
On Thu, Jul 25, 2013 at 11:14:59AM +0200, Jean-Francois Moine wrote:
[snip]
- priv->clk = devm_clk_get(&pdev->dev, NULL);
- priv->clk = devm_clk_get(&pdev->dev, "internal"); if (IS_ERR(priv->clk)) {
dev_err(&pdev->dev, "no clock\n");
dev_err(&pdev->dev, "no internal clock\n");Does the code providing it already name the clock? If not are updates needed to do that?
I don't know. I will reset the clock name to NULL when no DT, so it will be compatible.
- priv->extclk = clk_get(&pdev->dev, "extclk");
- priv->extclk = clk_get(&pdev->dev, "external");
Is the clock actually called extclk in the datasheet and so on? If so it seems better to stick with that name. Do any boards need updates for the new name?
"AU_EXTCLK" is the exact name (pasted out of the documentation). I don't see any purpose to this name changing.
On Tue, Jul 23, 2013 at 02:59:06PM +0200, Sebastian Hesselbarth wrote:
As Sascha Hauer pointed out, clocks should be distinguished by names (clock-names property) instead of position and then use devm_clk_get(&pdev->dev, "internal") and devm_clk_get(&pdev->dev, "external") respectively.
This will possibly also require to update platform_data and legacy users of kirkwood-i2s or have different setup functions for non-DT and DT.
The A510 documentation uses the names "DCO PLL" for the internal clock and "AU_EXTCLK" for the external clock. So, what about "dcopll" and "extclk"?