Hi Shenghao,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on broonie-sound/for-next] [also build test WARNING on linus/master v6.3-rc3 next-20230320] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shenghao-Ding/ASoC-tas2781-Ad... base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next patch link: https://lore.kernel.org/r/20230320150726.20573-1-13916275206%40139.com patch subject: [PATCH v4] ASoC: tas2781: Add tas2781 driver config: sparc-allyesconfig (https://download.01.org/0day-ci/archive/20230321/202303210435.ij3d6YHB-lkp@i...) compiler: sparc64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/9620831afc4c833413c073a5b991d0... git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Shenghao-Ding/ASoC-tas2781-Add-tas2781-driver/20230320-231125 git checkout 9620831afc4c833413c073a5b991d0f9be570754 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sparc SHELL=/bin/bash sound/soc/codecs/
If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot lkp@intel.com | Link: https://lore.kernel.org/oe-kbuild-all/202303210435.ij3d6YHB-lkp@intel.com/
All warnings (new ones prefixed by >>):
sound/soc/codecs/tas2781-i2c.c: In function 'tasdevice_tuning_switch':
sound/soc/codecs/tas2781-i2c.c:1007:13: warning: variable 'is_set_glb_mode' set but not used [-Wunused-but-set-variable]
1007 | int is_set_glb_mode = 0; | ^~~~~~~~~~~~~~~ sound/soc/codecs/tas2781-i2c.c: At top level: sound/soc/codecs/tas2781-i2c.c:42:27: warning: 'dts_dev_addr_tag' defined but not used [-Wunused-const-variable=] 42 | static const char * const dts_dev_addr_tag[] = { | ^~~~~~~~~~~~~~~~
vim +/is_set_glb_mode +1007 sound/soc/codecs/tas2781-i2c.c
1001 1002 static void tasdevice_tuning_switch( 1003 struct tasdevice_priv *tas_dev, int state) 1004 { 1005 struct tasdevice_fw *tas_fmw = tas_dev->fmw; 1006 int profile_cfg_id = 0;
1007 int is_set_glb_mode = 0;
1008 1009 if (state == 0) { 1010 if (tas_fmw) { 1011 if (tas_dev->cur_prog >= tas_fmw->nr_programs) 1012 /*bypass all in rca is profile id 0*/ 1013 profile_cfg_id = RCA_CONFIGID_BYPASS_ALL; 1014 else { 1015 /*dsp mode or tuning mode*/ 1016 profile_cfg_id = 1017 tas_dev->rcabin.profile_cfg_id; 1018 1019 is_set_glb_mode = 1020 tasdevice_select_tuningprm_cfg(tas_dev, 1021 tas_dev->cur_prog, 1022 tas_dev->cur_conf, 1023 profile_cfg_id); 1024 if (tas_dev->set_global_mode != NULL) 1025 tas_dev->set_global_mode(tas_dev); 1026 } 1027 } else 1028 profile_cfg_id = RCA_CONFIGID_BYPASS_ALL; 1029 1030 tasdevice_select_cfg_blk(tas_dev, profile_cfg_id, 1031 TASDEVICE_BIN_BLK_PRE_POWER_UP); 1032 } else 1033 tasdevice_select_cfg_blk(tas_dev, 1034 tas_dev->rcabin.profile_cfg_id, 1035 TASDEVICE_BIN_BLK_PRE_SHUTDOWN); 1036 } 1037