On Sun, 23 May 2021 11:03:26 +0200, Geoffrey D. Bennett wrote:
Hi Takashi,
This patch seems legitimate to me (although I would adjust whitespace so the second line doesn't go over 80 chars). Do you want to just apply it as-is, or do you want me to send a second version of my patch without this problem or send a new patch similar to this one?
As it's an obviously correct patch, I already applied as is.
thanks,
Takashi
Also sorry I don't know what the etiquette is in cc's for this message :(. The message from kernel test robot was sent to a lot of people who I don't think would be interested in this, so I trimmed the cc list down.
Thanks, Geoffrey.
On Sun, May 23, 2021 at 02:09:00AM +0800, kernel test robot wrote:
sound/usb/mixer_scarlett_gen2.c:2000:5: warning: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static?
Fixes: 265d1a90e4fb ("ALSA: usb-audio: scarlett2: Improve driver startup messages") Reported-by: kernel test robot lkp@intel.com Signed-off-by: kernel test robot lkp@intel.com
mixer_scarlett_gen2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/sound/usb/mixer_scarlett_gen2.c b/sound/usb/mixer_scarlett_gen2.c index 3ad8f61a2095f..4caf379d5b991 100644 --- a/sound/usb/mixer_scarlett_gen2.c +++ b/sound/usb/mixer_scarlett_gen2.c @@ -1997,8 +1997,8 @@ static int scarlett2_mixer_status_create(struct usb_mixer_interface *mixer) return usb_submit_urb(mixer->urb, GFP_KERNEL); }
-int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
const struct scarlett2_device_info *info)+static int snd_scarlett_gen2_controls_create(struct usb_mixer_interface *mixer,
const struct scarlett2_device_info *info){ int err;