Re: [alsa-devel] [PATCH 3/5] ALSA: ASoC: McASP: add support for 24 bit samples

On 09.10.2012 09:17, Mark Brown wrote:

On Thu, Oct 04, 2012 at 03:08:40PM +0200, Daniel Mack wrote:

...

• case SNDRV_PCM_FORMAT_U24_3LE:
• case SNDRV_PCM_FORMAT_S24_3LE:
• case SNDRV_PCM_FORMAT_U24_LE:
• case SNDRV_PCM_FORMAT_S24_LE:

• dma_params->data_type = 3;
  

• word_length = DAVINCI_AUDIO_WORD_24;
  

• break;
  

This is fine but should be adding the format to the set of supported formats in the DAI as well, otherwise userspace should never select 24 bits.

Thanks for the review! I'll quickly resend this one.