Re: [alsa-devel] [PATCH 06/14] ALSA: pcm: Shuffle codes

On Fri, 26 May 2017 15:06:29 +0200, Takashi Sakamoto wrote:

On May 26 2017 04:17, Takashi Iwai wrote:

...

Just shuffle the codes, without any change otherwise.

Signed-off-by: Takashi Iwai tiwai@suse.de

sound/core/pcm_lib.c | 210 +++++++++++++++++++++++++-------------------------- 1 file changed, 105 insertions(+), 105 deletions(-)

diff --git a/sound/core/pcm_lib.c b/sound/core/pcm_lib.c index e4f5c43b6448..5db086748515 100644 --- a/sound/core/pcm_lib.c +++ b/sound/core/pcm_lib.c > ... @@ -2117,19 +2179,6 @@ static snd_pcm_sframes_t snd_pcm_lib_write1(struct snd_pcm_substream *substream, } /* sanity-check for read/write methods */ -static int pcm_sanity_check(struct snd_pcm_substream *substream) -{

• struct snd_pcm_runtime *runtime;
• if (PCM_RUNTIME_CHECK(substream))

• return -ENXIO;
  

• runtime = substream->runtime;
• if (snd_BUG_ON(!substream->ops->copy_user && !runtime->dma_area))

• return -EINVAL;
  

• if (runtime->status->state == SNDRV_PCM_STATE_OPEN)

• return -EBADFD;
  

• return 0;

-}

The function comment should be involved to this move.

Yep, corrected.

thanks,

Takashi