On 15/08/2019 16.56, Pierre-Louis Bossart wrote:
Actually you *can* test by submitting a PR for SOF, it'll trigger some tests on Intel platforms using DPCM. It's not going to test anything related to the compressed API but it's better than nothing.
Good to know and thanks. I would not thought of abusing the SOF project to run tests, not that I know how to trigger the right tests ;)
well we will run those tests anyways when we do the weekly merges, and when in doubt it might be more productive for an ALSA contributor to run the tests ahead of time than report that things are broken after the merge (as seen 2 weeks in a row with the module_put and compilation issues)
I'll keep in mind, do you have some documentation on the tests?
I took this patch and created one PR as an example https://github.com/thesofproject/linux/pull/1132
Should I be worried because of your comment there saying 'I have no idea why the BYT_NOCODEC mode fails, there's no information provided.' ?
Redoing the tests removes that error, so this looks fine. Must have been a CI glitch
Hrm, did it had the same failure w/o my patch? Reordering tests might just hide a bug somewhere...
Will share results when I have them.
So far no issues. so FWIW since it's just 1st order automatic testing
Tested-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com
Thank you! - Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki