Re: [alsa-devel] [PATCH 8/9] ASoC: Intel: Atom: work-around Coccinelle false-alarm

On Sun, 16 Dec 2018, Pierre-Louis Bossart wrote:

Coccinelle complains: sst-atom-controls.c:1534:2-19: ERROR: Assignment of bool to non-0/1 constant

false alarm: that constant is declared as

Using a test that will be optimized away to work-around the issue

I'll improve the rule. It would be better to leave the code as it is.

julia

Cc: Julia Lawall julia.lawall@lip6.fr Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

---

sound/soc/intel/atom/sst-atom-controls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst-atom-controls.c b/sound/soc/intel/atom/sst-atom-controls.c index d1207ea53523..d00990852fdf 100644 --- a/sound/soc/intel/atom/sst-atom-controls.c +++ b/sound/soc/intel/atom/sst-atom-controls.c @@ -1531,7 +1531,7 @@ int sst_dsp_init_v2_dpcm(struct snd_soc_component *component) snd_soc_dapm_new_widgets(dapm->card);

for (i = 0; i < gains; i++) {

• sst_gains[i].mute = SST_GAIN_MUTE_DEFAULT;
  

• sst_gains[i].mute = SST_GAIN_MUTE_DEFAULT ? true : false;
  

  sst_gains[i].l_gain = SST_GAIN_VOLUME_DEFAULT; sst_gains[i].r_gain = SST_GAIN_VOLUME_DEFAULT; sst_gains[i].ramp_duration = SST_GAIN_RAMP_DURATION_DEFAULT;

-- 2.17.1