Re: [alsa-devel] soc_enum has issues

On 7/23/08, Jon Smirl jonsmirl@gmail.com wrote:

It is treating mask like a max:

dapm_connect_mux... struct soc_enum *e = (struct soc_enum *)kcontrol->private_value; int i;

    for (i = 0; i < e->mask; i++) {
            if (!(strcmp(control_name, e->texts[i]))) {

This looks like an error. I don't think there is a requirement that the number of elements in an enum be a power of two.

I went through the code and it looks ok. The name of the variable is just wrong, it should be max instead of mask. I'll change it in the next patch.

Next patch's goal is cleaning everything up for 32 bits instead of 16.

-- Jon Smirl jonsmirl@gmail.com