18 Jul
2018
18 Jul
'18
12:46 p.m.
On Tue, Jul 17, 2018 at 06:49:09PM -0600, Daniel Kurtz wrote:
From: Akshu Agrawal akshu.agrawal@amd.com
DA7219's VDDIO for our platform need to be configured for 1.8V. Hence we register a fixed 1.8V voltage regulator in the machine driver.
Change-Id: I65fd93e1dd37c3e0d38265b4b1492ea53b93afd4
Again, please don't include noise like this in upstream submissions.
+++ b/sound/soc/amd/Kconfig @@ -8,6 +8,7 @@ config SND_SOC_AMD_CZ_DA7219MX98357_MACH select SND_SOC_DA7219 select SND_SOC_MAX98357A select SND_SOC_ADAU7002
- select REGULATOR depends on SND_SOC_AMD_ACP && I2C
This seems inappropriate, I'd expect a dependency and if it were to stay a select it's also not selecting all the bits required to make this do something useful.