Re: [alsa-devel] [PATCH - Preliminary support for Xonar Xense (resubmitAdded support for Xonar Xense. Only speaker out and mic in working.

Ian Dawes wrote:

Signed-off-by: Ian Dawes madeallup.gen@gmail.com

The commit message was squashed into the subject line. There's probably an empty line missing between them.

+++ b/sound/pci/oxygen/xonar_pcm179x.c +static void xonar_xense_init(struct oxygen *chip) +{

• struct xonar_pcm179x *data = chip->model_data;
• data->generic.ext_power_reg = OXYGEN_GPI_DATA;
• data->generic.ext_power_int_reg = OXYGEN_GPI_INTERRUPT_MASK;
• data->generic.ext_power_bit = GPI_EXT_POWER;
• xonar_init_ext_power(chip);
• xonar_st_init(chip);

+}

How much of this is guesswork? :-)

Shouldn't you rather use xonar_stx_init(), which does not try to configure the nonexistent CS2000 chip?

• case 0x8428:

• chip->model = model_xonar_st;
  

• chip->model.shortname = "Xonar Xense";
  

• chip->model.chip = "AV100";
  

• chip->model.init = xonar_xense_init;
  

• chip->model.dac_channels_pcm = 8;
  

• chip->model.dac_channels_mixer = 8;
  

When only two channels work, why declaring more?

Regards, Clemens