14 Jul
2014
14 Jul
'14
6:18 p.m.
On 07/14/2014 05:46 PM, Arnd Bergmann wrote: [...]
+static struct gpiod_lookup_table smartq_audio_gpios = {
- .dev_id = "smartq-audio",
- .table = {
GPIO_LOOKUP("GPL", 12, "headphone detect", 0),GPIO_LOOKUP("GPK", 12, "amplifiers shutdown", GPIO_ACTIVE_HIGH),There is no such thing as GPIO_ACTIVE_HIGH, just 0 for flags.
The original driver does gpio_direction_output(..., 1);
For some reason I earlier concluded that this was what the '1' would need to get converted to. Are you sure '0' is correct then?
Yes. But now that you say it the gpiod_direction_output() call is missing from this patch.
- Lars