On 4/19/18 1:08 AM, Vinod Koul wrote:
On Thu, Apr 19, 2018 at 12:19:28AM -0700, Pierre-Louis Bossart wrote:
On 4/18/18 11:36 PM, Vinod Koul wrote:
static bool _is_codec_type_supported(int fd, struct snd_codec *codec) { struct snd_compr_caps caps; @@ -271,16 +228,6 @@ struct compress *compress_open(unsigned int card, unsigned int device, config->fragments = caps.max_fragments; } -#if 0
- /* FIXME need to turn this On when DSP supports
* and treat in no support case*/- if (_is_codec_supported(compress, config, &caps) == false) {
oops(compress, errno, "codec not supported\n");goto codec_fail;- }
-#endif
Why was this commented out in the first place?
It depends on capabilities being reported properly which wasn't the case so we had to turn it off...
This seems like a valid check to me. If the application is asking for a codec that isn't supported by hardware, should it be allowed to proceed?
It has been dead for quite some time, I don't know if ppl are reporting properly. Turning it on might break which is something I would like to avoid
It was broken so it's better to remain broken to avoid breaking things? TGIF.