On Fri, Dec 21, 2018 at 7:33 PM Mark Brown broonie@kernel.org wrote:
I can apply the patch via merge, so bothering with this is not at all necessary, but if this change is useful, perhaps it's worth submitting another patch for it. I doubt this though, as it looks a bit hackish to me.
It's useful (that's a genuine issue) but it shouldn't be bodged by TDM mode but should instead just be done as standard without the machine driver needing to do TDM - check if the clock rate required is actually generated then fall back to a less exact frame if that helps. That way everyone gets the benefit without needing custom configuration or code. Basically it's doing the right thing in terms of configuring the hardware but should be triggered differently.
I suspected as much; I'll need to read up a bit on clocking though if I'm going to give this a shot. I'll be away from my computer during the holidays so, if time permits, I'll give it a try with the new year and open a new thread if I need feedback. Thanks again for all your help so far.