Re: [PATCH] ALSA: control: Keep the previous numid at snd_ctl_rename_id()

On 06. 06. 23 11:40, Takashi Iwai wrote:

We don't need to change the numid at each time snd_ctl_rename_id() is called, as the control element size itself doesn't change. Let's keep the previous numid value.

I would also highlight in the comment that snd_ctl_rename_id() should be used only in the card initialization phase. It may cause issues with the user space (persistent numid) for the dynamic controls.

Reviewed-by: Jaroslav Kysela perex@perex.cz