That's progress but is this complete?
skl->i2s_dev->name is the name of the machine driver, I don't see the part where this is modified to deal with the number of dmics?
In your topology patches, the names are: hda_dsp_noDMIC hda_dsp_DMIC_2ch hda_dsp_DMIC_4ch
How would the relevant file be found based on the number of DMICs on the platform? I must be missing something here?
The intention of this patch was not to deal with the different DMIC configurations problem. It only simplifies the topology binary selection. As you mentioned in one of previous mails, currently there are two options:
- name based on NHLT, which is pretty complicated, especially for end user, and is also depending on things like OEM name so the same topology will need to be renamed multiple times different devices (additionally, there are laptops on the market that do not have NHLT table at all)
- dfw_sst.bin, which is only a fallback binary name and should not be actually used because it could be misleading for users/distro intergrators
This change adds the third option, which is, in my opinion, the right way to deal with this problem. This name is simpler, does not depend on existence of NHLT, and makes life easier for users/distros.
And as for the mentioned DMIC confguration problem - I am doing a research to find the simplest way to deal with this.
Mateusz