On 10/16/2013 06:04 PM, Mark Rutland wrote:
On Thu, Oct 10, 2013 at 06:29:59PM +0100, Peter Ujfalusi wrote:
On 10/10/2013 07:59 PM, Mark Rutland wrote:
No, they're not actually of much practical use to us at the minute but it was generally felt better to include the information and not use it so that if someone does come up with a use for them then the trees for deployed systems already have the information.
Sure, but if this device can generate multiple interrupts, we should make it possible to describe all of them, unambiguously.
This is why Jyri added them to the DT. They are not used by the Linux driver, but the HW have interrupt lines (two of them: TX and RX).
The binding only describes a single interrupt, and even if multiple interrupts were listed, there's no way to disambiguate them (e.g. interrupt-names).
It would be nice to remedy this.
This has been fixed in a later patch in the same series here:
[RESEND PATCH v3 05/11] ASoC: davinci-mcasp: Interrupts property to optional and add interrupt-names http://mailman.alsa-project.org/pipermail/alsa-devel/2013-September/066732.h...
However the v3 series is already obsolete. The latest posted series is v4. There the patch patch bellow inculdes interrupt names, plus some other improvements based on your comments earlier:
[PATCH v4 05/10] ASoC: davinci-mcasp: Improve DT bindings document http://mailman.alsa-project.org/pipermail/alsa-devel/2013-October/067100.htm...
There is already couple of updates even to v4 series of the patches, here:
[PATCH v4.1 08/10] ARM/dts: am33xx: mcasp: Add location for data port registers to reg-property http://mailman.alsa-project.org/pipermail/alsa-devel/2013-October/067125.htm...
[PATCH v4.2 09/10] ARM/dts: am335x-evm: Add audio support for am335x-evm.dts http://mailman.alsa-project.org/pipermail/alsa-devel/2013-October/067133.htm...
[PATCH v4.2 10/10] ARM/dts: am335x-evmsk: Audio support http://mailman.alsa-project.org/pipermail/alsa-devel/2013-October/067140.htm...
Best regards, Jyri