Hi Geraldo, Mark,
在 2022/8/17 1:54, Geraldo Nascimento 写道:
On Tue, Aug 16, 2022 at 04:22:37PM +0100, Mark Brown wrote:
On Tue, Aug 16, 2022 at 10:37:18AM -0300, Geraldo Nascimento wrote:
This isn't my patch, it's a patch by Sugar Zhang from Rockchip that was supposed to have been applied one year ago, give or take 10 days. I can't resend a patch that wasn't authored by me.
There's absolutely no problem with reposting someone else's patch - just add your Signed-off-by at the end of the signoff chain.
Mark, I'm in no position to lecture anyone, least of who, you, hard-working ASoC maintainer that you are. But there are *tons* of problems with reposting someone else's patch, even if they had been previously given the green-light but misteriously vanished.
You are assuming responsibility for someone else's work! Let's see in this case what would happen:
In this case, the Rockchip I2S missing reset affair, I have tested the proposed changes, and they are OK, *if* you add the reset properties in the device tree.
For example, I was playing with HDMI sound on the RK3399pro Radxa Rock Pi N10 and I added the following properties to my private rk3399.dtsi:
--- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi @@ -1695,6 +1695,8 @@ i2s2: i2s@ff8a0000 { dma-names = "tx", "rx"; clock-names = "i2s_clk", "i2s_hclk"; clocks = <&cru SCLK_I2S2_8CH>, <&cru HCLK_I2S2_8CH>;
reset-names = "reset-m", "reset-h";resets = <&cru SRST_I2S2_8CH>, <&cru SRST_H_I2S2_8CH>;
And once I okay &i2s2 and &hdmi_sound inside rk3399pro-vmarc-som.dtsi I get kind of working HDMI sound, very clipped, I have to software adjust the volume to 30% to get clean, not speaker-blowing sound. But I digress, the point that it kinda works is not the point at all.
My main point is that without adding "resets" and "reset-names" to *at least* every Rockchip device tree that enables sound over HDMI, just an example, you get systems with non-working HDMI. I just tested it, I omitted "resets" and "reset-names" from my device tree and then had to SSH into the black screen to revert the changes to my boot partition.
Actually, the reset is used for i2s SLAVE mode which may fail to clear if the MASTER
side stop the clk before i2s done. in this situation, we do reset the controller and
bring it back to normal state.
But, for HDMI sound, the i2s works as MASTER mode and should not be fail to clear.
could you share your I2S and HDMI register dump to me to dig out the root cause.
OTOH，I have noticed that some patchs ignored on upstream, I will check and repost
those patchs.
So it's not trivial to RESEND this. It amounts to device tree overhaul of arch/arm64/boot/dts/rockchip
This would require community effort of say, equivalent to LibreELEC resources, which are not many, but they have enough patience to test every proposed change to Rockchip device trees, and could help upstream this.
Thank you, Geraldo Nascimento