Re: [alsa-devel] [PATCH 6/6] ASoC: ux500: Use the first two AD slots for capture

On Wed, 08 May 2013, Mark Brown wrote:

On Wed, May 08, 2013 at 09:14:21AM +0200, Fabio Baltieri wrote:

...

Set AD_OUT1 and AD_OUT2, corresponding to LINL and LINR pins, as the default input slots for the capture interfaces.

If these are routing specific analogue inputs to specific timeslots then this is routing that should be being exposed to DAPM as muxes, not hard coded in the middle of TDM slot configuration (which is both obscure and not what the TDM API is there for). The TDM API should be purely about placing the timeslots for the audio interface on the bus.

Again, I think this patch is a valid bugfix. If the driver requires refactoring, it should be done by someone else. That's not the purpose of Fabio's role.