Hi!
On Mon, Feb 29, 2016 at 05:10:34PM +0100, Takashi Iwai wrote:
On Mon, 29 Feb 2016 16:05:20 +0100, Thomas Klausner wrote:
From: Thomas Klausner wiz@NetBSD.org
include/sound/asound.h | 4 ++--
Sorry, this is no-go. The files in include/sound/* are basically copies of Linux ABI. So, all these files must not be modified in alsa-lib side. And, using __kernel_off_t there is in purpose -- to distinguish from the user-space off_t.
That said, the best workaround for these files are to provide the compatible typedefs.
So how about the attached patch instead?
OTOH, the code changes in include/pcm.h and src/pcm/* are acceptable, in general, but I still hesitate to apply it, so far. If it's only about portability, we may wrap it with a few typedefs instead of touching so many lines. And it would bring any other real benefit? It's the question...
I still prefer uint* to u_int* because uint* is in POSIX and u_int* is not, but I added the necessary defines in the new patch. Thomas