On Mar 19, 2019, at 8:37 AM, Mark Brown broonie@kernel.org wrote:
On Mon, Mar 18, 2019 at 08:37:55PM -0700, Annaliese McDermond wrote:
Different processing blocks are required for different sampling rates and power parameters. Set the processing blocks based on this information.
Is this another bug fix or does it depend on the rest of the series somehow?
It’s not really a bug fix. The codec has a variety of “processing blocks” that enable different filters (there’s an onboard FIR, Biquad, etc.) and such. The big thing they change with regard to how the driver is written now is that they change the decimation filter used. The documentation specifies to use certain filters for certain sample rates. This hasn’t mattered very much in the past because the default filters (P1 and R1) are the ones recommended for 48kHz and below. This is particularly important for 192kHz operation because it won’t work with P1 and R1. So, it’s not really a bug fix. It’s part of the road to enabling 192kHz operation.
-- Annaliese McDermond nh6z@nh6z.net