On Thursday 16 December 2010 15:55:05 ext Mark Brown wrote:
On Thu, Dec 16, 2010 at 03:51:13PM +0200, Peter Ujfalusi wrote:
It behaves mostly OK, but there's a strange side effect: I noticed a pop on playback stream start on the twl4030 codec. I'll look into it, but I do not see how this patch can affect the stream start..
Indeed, it should result in an extra comparison in the middle of the DAPM sequence which oughtn't to have any effect here. Is it possible that some of the other updates that have been going in recently such as the cross-device changes introduced this, or is it definitely just this one patch?
Found the reason.. The pop is there without this patch, it is coming from the output amp power up. In normal use case, it is filtered by the external amp, but I use non convetional setup at the moment, and that is the reason for the pop. I need to take a look at this at some time :(
Could you hold this patch for some time, so I can look at this?
Sure.
Thanks, You can pick either of my:
Acked-by: Peter Ujfalusi peter.ujfalusi@nokia.com Tested-by: Peter Ujfalusi peter.ujfalusi@nokia.com