diff --git a/sound/soc/codecs/rt712-sdca-dmic.c b/sound/soc/codecs/rt712-sdca-dmic.c new file mode 100644 index 000000000000..e5d765d84369 --- /dev/null +++ b/sound/soc/codecs/rt712-sdca-dmic.c @@ -0,0 +1,991 @@ +// SPDX-License-Identifier: GPL-2.0-only // // rt712-sdca-dmic.c -- +rt712 SDCA DMIC ALSA SoC audio driver // // Copyright(c) 2023 Realtek +Semiconductor Corp. +// +//
+#include <linux/bitops.h> +#include <sound/core.h> +#include <linux/device.h> +#include <linux/delay.h> +#include <linux/init.h> +#include <sound/initval.h> +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/moduleparam.h> +#include <linux/mod_devicetable.h> +#include <linux/pm_runtime.h> +#include <sound/pcm.h> +#include <sound/pcm_params.h> +#include <linux/soundwire/sdw_registers.h> #include <linux/slab.h> +#include <sound/soc-dapm.h> #include <sound/tlv.h>
Ordering of those includes seems bit weird to me, can't you include sound/ ones after linux/ ones?
And a bit of nitpicking linux/moduleparam.h seems redundant if you include linux/module.h
And I'm not sure why do you need linux/delay.h, I don't see any *sleep or *delay functions in the patch?
Thanks for reviewing. I will re-order the includes and remove redundant ones.
+#include "rt712-sdca.h" +#include "rt712-sdca-dmic.h"
...
------Please consider the environment before printing this e-mail.