Re: [alsa-devel] [PATCH] alsa: echoaudio - pci id cleanup

On 11/04/2009 09:25 AM, Takashi Iwai wrote:

At Sat, 17 Oct 2009 11:48:23 +0200, Tim Blechmann wrote:

...

using the PCI_VENDOR_ID_MOTOROLA definition instead of the value 0x1057 makes code a bit cleaner.

Signed-off-by: Tim Blechmann tim@klingt.org

Well, I'm not always fond of this. The only merit is that you can avoid a typo. But, if you look for a device from the source code from lspci, this kind of change makes it hard.

it helps, if this device is referred to by PCI_VENDOR_ID_MOTOROLA instead of 0x1057, as it is done somewhere in the cardbus code ...

but since it is a rather cosmetic fix, feel free to drop the patch ...

tim