Re: [PATCH v3 3/3] ASoC: codec: lpass-rx-macro: add support for 2.5 codec version

On 12/06/2024 19:18, Dmitry Baryshkov wrote:

...

• memcpy(&reg_defaults[0], rx_defaults, sizeof(rx_defaults));
• memcpy(&reg_defaults[ARRAY_SIZE(rx_defaults)],

• 	rx_pre_2_5_defaults, sizeof(rx_pre_2_5_defaults));
  

• switch (rx->codec_version) {
• case LPASS_CODEC_VERSION_2_5 ... LPASS_CODEC_VERSION_2_8:

I don't like that the next 2.9 version will end up in a default bucket. It might be better to have an explicit list of versions instead and then return -EINVAL in the default case.

makes sense

--srini