On 10/08/24 04:56, Mark Brown wrote:
On Fri, Aug 09, 2024 at 01:49:37PM +0530, Mukunda,Vijendar wrote:
On 09/08/24 13:05, Mark Brown wrote:
We want the resulting git tree to be bisectable, that means testing each commit not just the final result.
This patch series is prepared on top of 20240801111821.18076-1-Vijendar.Mukunda@amd.com which are incremental changes and also has dependency.
For the benefit of those playing at home that's "ASoC: intel/sdw_utils: move dai id common macros" which is in -next as 8f87e292a34813e. It's not great to base a fix for something that's in Linus' tree like this one which has:
Fixes: 96eb81851012 ("ASoC: SOF: amd: add interrupt handling for SoundWire manager devices")
in it, and any such dependency really needs to get called out in the cover letter if it exists.
Agreed. Will mention the patch dependency in the cover letter and resend the patch series.
In general you should expect bug fixes to be applied for Linus' tree by default, especially if they're tagged as fixing a particular commit in there. That means no dependencies on anything that's already in -next unless explicitly called out, and if the thing in -next is just a cleanup or refactoring then generally it's best to just do the fix for Linus' tree and then separately merge it up to -next and integrate with whtaever cleanup/refactoring is going on there.
Please include human readable descriptions of things like commits and issues being discussed in e-mail in your mails, this makes them much easier for humans to read especially when they have no internet access. I do frequently catch up on my mail on flights or while otherwise travelling so this is even more pressing for me than just being about making things a bit easier to read.