Hello Rob, Mark
Thanks for your review. Please find my comments below.
On 04/11/2017 04:32 PM, Mark Brown wrote:
On Mon, Apr 10, 2017 at 02:48:32PM -0500, Rob Herring wrote:
On Thu, Apr 06, 2017 at 05:40:35PM +0200, olivier moysan wrote:
+Required properties:
- compatible: Must be "st,stm32h7-i2s"
- #sound-dai-cells: Must be 1. (one parameter)
- This parameter allows to specify CPU DAI index in soundcard CPU dai link.
- index 0: playback DAI
- index 1: capture DAI
- index 2: full duplex DAI
Is this still needed for graph-card?
The graph card is blocked on your review... I'm also not clear how without something like this we'd be able to identify a specific DAI within a device if we don't have a way of identifying them.
Yes, it seems that audio graph card does not allow to select a specific DAI. This will probably be necessary.
However, regarding STM32 I2S driver, I'm wondering if selecting DAI is the best way to configure interface as tx, rx or fd. Maybe, it is more relevant to configure DAI according to DMA configuration from I2S node. This would moreover avoid to allocate 2 dmas channels when not necessary (tx or rx only). If you agree with this, I will implement this change in a v2.
BRs olivier