Re: [alsa-devel] [PATCH 2/2] ac97: YMF743 missing controls support

At Wed, 19 Sep 2007 00:50:54 +0900, Keita Maehara wrote:

From: Keita Maehara maehara@debian.org

These patches enable a few YMF743 controls (Tone/3D/IEC958) that won't be detected with the current version of ALSA.

Signed-off-by: Keita Maehara maehara@debian.org

The changes look good to me, but I'd like to ask you to rewrite the patch to follow the standard coding style. Yes, the original ac97 code doesn't follow, but at least, we should do it right for the newly added/changed codes. For example, keep lines within 80 chars, fold lines appropriately, avoid if ((err = ...)) style, etc.

In doubt, you can run scripts/checkpatch.pl in the linux kernel tree.

Thanks,

Takashi