On Tue, 04 Aug 2015 05:58:39 +0200, Vinod Koul wrote:
From: Jeeja KP jeeja.kp@intel.com
The snd_hdac_chip_readl return can never be less than zeros, so no point in checking for the return value
This fixes following static checker warnings in snd_hdac_ext_bus_parse_capabilities
sound/hda/ext/hdac_ext_controller.c:47snd_hdac_ext_bus_parse_capabilities() warn: unsigned 'offset' is never less than zero.
sound/hda/ext/hdac_ext_controller.c:54snd_hdac_ext_bus_parse_capabilities() warn: unsigned 'cur_cap' is never less than zero.
Signed-off-by: Jeeja KP jeeja.kp@intel.com Reported-by: Dan Carpenter dan.carpenter@oracle.com Signed-off-by: Vinod Koul vinod.koul@intel.com
Applied, thanks.
Takashi
sound/hda/ext/hdac_ext_controller.c | 6 ------ 1 file changed, 6 deletions(-)
diff --git a/sound/hda/ext/hdac_ext_controller.c b/sound/hda/ext/hdac_ext_controller.c index b2da19b60f4e..358f16195483 100644 --- a/sound/hda/ext/hdac_ext_controller.c +++ b/sound/hda/ext/hdac_ext_controller.c @@ -44,16 +44,10 @@ int snd_hdac_ext_bus_parse_capabilities(struct hdac_ext_bus *ebus)
offset = snd_hdac_chip_readl(bus, LLCH);
if (offset < 0)
return -EIO;/* Lets walk the linked capabilities list */ do { cur_cap = _snd_hdac_chip_read(l, bus, offset);
if (cur_cap < 0)return -EIO;dev_dbg(bus->dev, "Capability version: 0x%x\n", ((cur_cap & AZX_CAP_HDR_VER_MASK) >> AZX_CAP_HDR_VER_OFF));
-- 1.9.1