On 8/19/21 10:06 AM, Cezary Rojewski wrote:
On 2021-08-19 4:30 PM, Pierre-Louis Bossart wrote:
On 8/19/21 3:24 AM, Lukasz Majczak wrote:
Sparse warnings triggered truncating the IDs of some platform device tables. Unfortunately kbl_da7219_max98373 was also truncated. This patch is reverting the original ID. Tested on Atlas chromebook.
Instead of reverting, how about changing the remaining occurrences of the old name in the machine driver?
sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name, "kbl_da7219_max98373") || sound/soc/intel/boards/kbl_da7219_max98927.c: .name = "kbl_da7219_max98373",
Mentioned by 'Fixes' tag patch clearly introduced regression. If we are to update any name-fields, it's better to have a fresh start and update all the boards in one-go than doing so separately.
Apart from that, Maxim codecs go by the name of 'max' in sound/soc/codecs/. It's more intuitive to have equivalent shortcut used in board's name.
the ACPI HID start with MX and there's not much consistency in naming, is there?
.drv_name = "kbl_r5514_5663_max", .drv_name = "kbl_rt5663_m98927", .drv_name = "kbl_da7219_mx98357a", .drv_name = "kbl_da7219_max98927", .drv_name = "kbl_max98373",
Reviewed-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com