Re: [alsa-devel] [PATCH v3 1/9] ASoC: fsl-ssi: Fix probe error handling

Hi,

On Thu, Dec 19, 2013 at 01:03:34PM +0000, Mark Brown wrote:

On Wed, Dec 18, 2013 at 12:57:37PM +0100, Markus Pargmann wrote:

...

This patch fixes the error handling in the fsl-ssi probe function.

This doesn't apply against current code, please check and resend.

Okay, I will rebase on your topic/fsl again.

...

error_irqmap:

• irq_dispose_mapping(ssi_private->irq);

• if (ssi_private->use_dma && !of_device_is_compatible(pdev->dev.of_node,

• 		"fsl,imx21-ssi"))
  

• irq_dispose_mapping(ssi_private->irq);
  

This test is icky, a flag set when we create the mapping would be neter.

Fixed.

Thanks,

Markus